[alsa-devel] [PATCH 21/30] ALSA: oxfw: Change the way to name card

[Takashi Iwai]

At Tue, 02 Dec 2014 00:05:31 +0900,
Takashi Sakamoto wrote:
> 
> On Dec 1 2014 20:21, Clemens Ladisch wrote:
> > (While the driver name often is name of the driver, it is also used to
> > select one of the configuration files in /usr/share/alsa/cards/.  The
> > FireWave and the LaCie speakers are often used for 'normal' 5.1 and 2.0
> > playback, and need different configurations, so I used different driver
> > names for these.
> > 
> > For these two devices, the driver name should stay the same.  All the
> > other snd-oxfw device are (semi)pro devices where it does not really
> > make sense to define devices like "surround51", so the driver name does
> > not matter and might as well be "OXFW".)
> 
> Exactly. If userspace didn't have the configuration files, I were
> willing to use 'OXFW' as driver name for all of models.
> 
> > As for the shortname, it is not an internal identifier but typically
> > displayed to identify the device for the user.  Something like
> > "FWSpeakers" might be recognizable, but I'd prefer the old "FireWire
> > Speakers".
> 
> In this case (the old name), 'Speakers' is an identical name such as
> 'hw:Speakers'. IMHO, this is a bit strange because it's usual, not
> identical.

You see now that you're breaking user's setup, don't you?
This is another reason why you shouldn't change the short name
string.  Keeping things running is more valuable than cleanup.


Takashi