[alsa-devel] [PATCH] ASoC: Intel: Add merrifield machine driver

[Subhransu S. Prusty]

On Tue, Aug 12, 2014 at 10:48:22PM +0100, Mark Brown wrote:
> On Tue, Aug 12, 2014 at 11:36:09AM +0530, Subhransu S. Prusty wrote:
> > On Tue, Jul 29, 2014 at 08:50:43PM +0100, Mark Brown wrote:
> > > On Thu, Jul 17, 2014 at 05:43:45PM +0530, Subhransu S. Prusty wrote:
> 
> > > > +	/* Force enable VMID to avoid cold latency constraints */
> > > > +	snd_soc_dapm_force_enable_pin(&card->dapm, "VMID");
> > > > +	snd_soc_dapm_sync(&card->dapm);
> 
> > > This looks like you're open coding a version of wm8994_vmid_mode().
> > > Though that might need some tuning for systems that really have no
> > > single ended outputs.
> 
> > VMID has a larget settling time. Keep it ON here to avoid the delay. Any
> > better way of doing this?
> 
> Look at what wm8994_vmid_mode() does...

If I understand correctly need to move this enabling/disabling of VMID
to wm8994_vmid_mode(). 


--