[alsa-devel] [PATCH] ALSA: hda - Do not assign streams in reverse order

[Takashi Iwai]

At Tue, 08 Apr 2014 10:50:18 +0300,
Anssi Hannula wrote:
> 
> 08.04.2014 10:35, Takashi Iwai kirjoitti:
> > At Mon,  7 Apr 2014 22:36:38 +0300,
> > Anssi Hannula wrote:
> >>
> >> Currently stream numbers are assigned in reverse order.
> >>
> >> Unfortunately commit 7546abfb8e1f9933b5 ("ALSA: hda - Increment
> >> default stream numbers for AMD HDMI controllers") assumed this was not
> >> the case (specifically, it had the "old cards had single device only"
> >> => "extra unused stream numbers do not matter" assumption), causing
> >> non-working audio regressions for AMD Radeon HDMI users on v3.14.
> >>
> >> Change the stream numbers to be assigned in increasing order instead.
> >>
> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77002
> >> Reported-by: Christian Güdel <cg at dmesg.ch>
> >> Signed-off-by: Anssi Hannula <anssi.hannula at iki.fi>
> >> Tested-by: Christian Güdel <cg at dmesg.ch>
> >> Cc: Alex Deucher <alexander.deucher at amd.com>
> >> Cc: <stable at vger.kernel.org> # 3.14
> >> ---
> >>
> >> Takashi, please check I didn't miss anything (I'm not that familiar
> >> with this low-level HDA code). :)
> > 
> > In that case, let's revert the commit instead.  There was a reason to
> > behave in that way, although I don't remember well.  That said, this
> > change might lead to another regression.  Thus, if a fix is needed for
> > stable, the revert would be the best choice as a first aid.  Of
> > course, this change is good to have, so let's implement this for 3.15
> > and see whether it works well for all nasty controllers.
> 
> We tested reverting (on top of v3.14) with Christian and it works as
> well, so you can add:
> Tested-by: Christian Güdel <cg at dmesg.ch>

OK, great.

> > Besides, this patch can't be applied any longer to the current code
> > base since it's been rewritten a lot; most of codes have been moved to
> > another file hda_controller.c.  Could you rebase the patch for the
> > latest tree?  Meanwhile I'll prepare a revert that is applied only to
> > 3.14.x.
> 
> Will do.

Thanks!


Takashi