[alsa-devel] [PATCH 23/44] fireworks: Add proc interface for debugging purpose

Clemens Ladisch clemens at ladisch.de
Thu Apr 3 23:16:49 CEST 2014


Takashi Sakamoto wrote:
> This commit adds proc interface to output infomation for debugging.
>  - firmware information
>  - sampling rate and clock source
>  - physical metering (linear value)
>
> +++ b/sound/firewire/fireworks/fireworks.c
> @@ -133,6 +133,16 @@ get_hardware_info(struct snd_efw *efw)
> +	/* hardware metering */
> +	efw->phys_out = hwinfo->phys_out;
> +	efw->phys_in = hwinfo->phys_in;
> +	efw->phys_out_grp_count = hwinfo->phys_out_grp_count;
> +	efw->phys_in_grp_count = hwinfo->phys_in_grp_count;

The driver relies on these values being correct.  It will blow up
if^H^Hwhen the firmware makes these values overflow.


Regards,
Clemens


More information about the Alsa-devel mailing list