[alsa-devel] [FFADO-devel] [PATCH 05/44] firewire-lib: Add support for MIDI capture/playback

[Clemens Ladisch]

Adrian Knoth wrote:
> On Wed, Apr 02, 2014 at 09:29:20PM +0200, Clemens Ladisch wrote:
>
>>> +		len = b[0] - 0x80;
>>> +		if ((len > 1) &&  (3 < len) && (s->midi[port]))
>>
>> This condition is true only for len==2.
>
> I don't know if len can be larger than 3. If so, the condition requires
> len to be at least 4.

Oops, you're right.  (The goal is do detect 1..3.)


Regards,
Clemens