[alsa-devel] [PATCH 08/14] ASoC: kirkwood: prefer external clock over internal clock

Mark Brown broonie at kernel.org
Mon Sep 2 13:01:05 CEST 2013


On Sun, Sep 01, 2013 at 06:41:53PM +0200, Jean-Francois Moine wrote:
> Russell King <rmk+kernel at arm.linux.org.uk> wrote:

> > +	} else if (rate == 44100 || rate == 48000 || rate == 96000) {

> The rate is always good, and having this test raises a compilation warning
> (clks_ctrl may be not initialized).

That should be fixed - it might be worth keeping the test and adding an
else with an error return for robustness.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130902/1e9ebb66/attachment.sig>


More information about the Alsa-devel mailing list