[alsa-devel] [PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support
Nicolin Chen
b42378 at freescale.com
Thu Oct 31 08:44:37 CET 2013
Hi, Philippe
On Thu, Oct 31, 2013 at 08:54:12AM +0100, Philippe Rétornaz wrote:
> Hi
>
> >
> >+ /* When using dual fifo mode, we need to keep watermark
> >+ * as even numbers due to dma script limitation.
> >+ */
> >+ ssi_private->dma_params_tx.maxburst /= 2;
> >+ ssi_private->dma_params_tx.maxburst *= 2;
> >+ ssi_private->dma_params_rx.maxburst /= 2;
> >+ ssi_private->dma_params_rx.maxburst *= 2;
> >
>
> Why not using a mask here ?
> ssi_private->dma_params_tx.maxburst &= ~0x1;
> ssi_private->dma_params_rx.maxburst &= ~0x1;
I'll use this in v3. Thank you!
Nicolin Chen
>
> Regards,
>
> Philippe
>
>
More information about the Alsa-devel
mailing list