[alsa-devel] [PATCH] ASoC: wm8962: Fix null pointer pdata access in I2C probe()

Nicolin Chen b42378 at freescale.com
Wed Oct 30 02:31:51 CET 2013


On Tue, Oct 29, 2013 at 09:35:56AM -0700, Mark Brown wrote:
> > -	for (i = 0; i < ARRAY_SIZE(pdata->gpio_init); i++)
> > -		if (pdata->gpio_init[i]) {
> > +	for (i = 0; i < ARRAY_SIZE(wm8962->pdata.gpio_init); i++)
> > +		if (wm8962->pdata.gpio_init[i]) {
> 
> ...it'd be neater to just ensure that pdata is always initialised.

I considered about that, and the patch could be neater. But then I
just found the code around this part are all using wm8962>pdata.*
pattern. So I stick the modification to it.

Thank you,
Nicolin Chen




More information about the Alsa-devel mailing list