[alsa-devel] [PATCH v2] ASoC: Add pinctrl PM to components of active DAIs

[Nicolin Chen]

Hi Kyungmin,

On Tue, Oct 29, 2013 at 12:35:06PM +0900, Kyungmin Park wrote:
> > +       /* deactivate pins to sleep state */
> > +       for (i = 0; i < card->num_rtd; i++) {
> > +               struct snd_soc_pcm_runtime *rtd = &card->rtd[i];
> > +               struct snd_soc_dai *cpu_dai = rtd->cpu_dai;
> > +               pinctrl_pm_select_sleep_state(cpu_dai->dev);
> 
> I wonder doesn't check it's active or not? if codec is used during
> suspend. it doesn't set sleep state?

I thought codec wouldn't do anything meaningful to cpu dai since the
whole system is going to suspend. But it should be better to add the
condition here as well. I'll send a v3.

Thank you for the comments,
Nicolin Chen