[alsa-devel] [PATCH 6/6] ALSA: Optimize module name check
Takashi Iwai
tiwai at suse.de
Mon Oct 28 14:14:10 CET 2013
module->name is a fixed array, so we can check the empty contents
straightforwardly in module_slot_match().
Spotted by coverity CID 1056786.
Signed-off-by: Takashi Iwai <tiwai at suse.de>
---
sound/core/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/init.c b/sound/core/init.c
index 6b90871..01a8938 100644
--- a/sound/core/init.c
+++ b/sound/core/init.c
@@ -66,7 +66,7 @@ static int module_slot_match(struct module *module, int idx)
#ifdef MODULE
const char *s1, *s2;
- if (!module || !module->name || !slots[idx])
+ if (!module || !*module->name || !slots[idx])
return 0;
s1 = module->name;
--
1.8.4.1
More information about the Alsa-devel
mailing list