[alsa-devel] [PATCH v2] ASoC: kirkwood: add S/PDIF support

[Russell King - ARM Linux]

On Sun, Oct 20, 2013 at 06:12:55PM +0100, Mark Brown wrote:
> On Fri, Oct 18, 2013 at 08:37:50PM +0200, Jean-Francois Moine wrote:
> > This patch adds S/PDIF input/output for mvebu DT boards.
> 
> This looks basically good, thanks.  A couple of things though:
> 
> > +	if (dai->name[0] == 'i')
> > +		ctl &= ~KIRKWOOD_PLAYCTL_SPDIF_EN;	/* i2s */
> > +	else
> > +		ctl &= ~KIRKWOOD_PLAYCTL_I2S_EN;	/* spdif */
> > +
> 
> This works and isn't actively a problem but it's not really normal
> either - the normal thing would be to use dai->id.
> 
> > +static struct snd_soc_dai_driver kirkwood_i2s_dai[2] = {
> > +    {
> > +	.name = "i2s",
> > +	.playback = {
> 
> This should cause problems for the existing (non-DT) machine drivers?
> They're using cpu_dai_name to bind the CPU DAI and you're now setting an
> explicit name instead of letting the dev_name() be used.  The patch
> should be updating those machine drivers too unless I'm missing
> something.

For your information, I intend to nobble you and Liam at the kernel
summit and knock your two heads together over this.  You both have
been dysfunctional over this driver and its about time someone banged
some sense into you both.