[alsa-devel] [PATCH 1/3] ALSA: hda - Treat zero connection as non-error

[Takashi Iwai]

At Thu, 17 Oct 2013 19:03:04 +0200,
David Henningsson wrote:
> 
> On 10/17/2013 06:32 PM, Takashi Iwai wrote:
> > The zero-length connection list happens so often on Haswell HDMI, and
> > it results in warning messages like
> >     ALSA: hda_codec: invalid CONNECT_LIST verb 5[1]:0
> > at each time the codec resumes from the power-save, which is fairly
> > annoying.
> 
> Agreed, but it's not the "invalid CONNECT_LIST verb" message you're
> changing, it's the "invalid dep_range_val" message?

Doh, you're right, just patched a wrong place.
The correct one is below.


thanks,

Takashi

---
From: Takashi Iwai <tiwai at suse.de>
Subject: [PATCH v2] ALSA: hda - Treat zero connection as non-error

The zero-length connection list happens so often on Haswell HDMI, and
it results in warning messages like
    ALSA: hda_codec: invalid CONNECT_LIST verb 5[1]:0
at each time the codec resumes from the power-save, which is fairly
annoying.

Since this is no real error, make it shown only in the verbose debug
mode.

Signed-off-by: Takashi Iwai <tiwai at suse.de>
---
 sound/pci/hda/hda_codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 68801ba..a1632f4 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -565,7 +565,7 @@ int snd_hda_get_raw_connections(struct hda_codec *codec, hda_nid_t nid,
 		range_val = !!(parm & (1 << (shift-1))); /* ranges */
 		val = parm & mask;
 		if (val == 0 && null_count++) {  /* no second chance */
-			snd_printk(KERN_WARNING "hda_codec: "
+			snd_printdd("hda_codec: "
 				   "invalid CONNECT_LIST verb %x[%i]:%x\n",
 				    nid, i, parm);
 			return 0;
-- 
1.8.4