[alsa-devel] [PATCH] ASoC: mc13783: add mixer controls

[Mark Brown]

On Wed, Oct 09, 2013 at 05:01:44PM +0200, Steffen Trumtrar wrote:

> +static const char * const mc13783_alsp[] = {"Off", "Codec", "Right"};
> +
> +static const char * const mc13783_ahs[] = {"Codec", "Mixer"};

What are these - these look like they might be DAPM rather than regular
controls?

> +	SOC_SINGLE("Headset Amp Right Switch", MC13783_AUDIO_RX0, 9, 1, 0),
> +	SOC_SINGLE("Headset Amp Left Switch", MC13783_AUDIO_RX0, 10, 1, 0),

I would expect these to be stereo controls rather than two mono
controls?

> +	SOC_ENUM("Line out Amp Switch", mc13783_enum_arxout),

Switches shouldn't be enums.

> +	SOC_SINGLE("Codec Capture Mix Switch", MC13783_AUDIO_RX0, 21, 1, 0),

CODEC and Codec seem to be getting mixed in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20131009/31711217/attachment.sig>