[alsa-devel] [PATCH v2] ASoC: imx-sgtl5000: do not use devres on a foreign device

Olof Johansson olof at lixom.net
Tue Oct 1 02:41:55 CEST 2013


Hi,

On Wed, Sep 25, 2013 at 6:21 AM, Philipp Zabel <p.zabel at pengutronix.de> wrote:

> Changes since v1:
>  - Rebased onto asoc/for-next, adding back imx_sgtl5000_remove.

[...]

> +static int imx_sgtl5000_remove(struct platform_device *pdev)
> +{
> +       struct imx_sgtl5000_data *data = platform_get_drvdata(pdev);
> +
> +       clk_put(data->codec_clk);
> +
> +       return 0;
> +}
> +

This function is never referenced nor called from anywhere, so if you
want to add it back you've better add a reference to it as well. :)

For now it results in:

sound/soc/fsl/imx-sgtl5000.c:185:12: warning: 'imx_sgtl5000_remove'
defined but not used [-Wunused-function]


-Olof


More information about the Alsa-devel mailing list