[alsa-devel] [PATCH 2/4] ASoC: Add support for the Analog Devices AXI-I2S core

[Mark Brown]

On Fri, Nov 29, 2013 at 02:04:48PM +0100, Lars-Peter Clausen wrote:

> We only use it on ZYNQ and Microblaze though. And people have complained in
> the past about symbols that are viable on their platform, but are not
> relevant for their platform. And to use the core on a different FPGA
> platform will most likely require changes to the core, unless the other FPGA
> also has a PL330 DMA interface. So I'd prefer to only make it avaiable on
> ZYNQ and Microblaze right now.

Is it really restricted to PL330 at the hardware level?  I don't recall
anything too fancy in the datasheet there.

> >> +	frame_size = AXI_I2S_BITS_PER_FRAME / 2 - 1;

> > This isn't obvious - usually the frame size is the number of bits per
> > frame.  Looking at the code I guess the hardware is more flexible than
> > the driver allows at the minute?

> that feature at the moment. But I'll add a comment explaining this. And
> maybe rename the variable from framesize to wordsize.

It definitely needs to be changed to word size.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20131129/e608e250/attachment.sig>