[alsa-devel] [PATCH 04/17] firewire-lib: Split some codes into functions to reuse in future

[Takashi Sakamoto]

(Nov 26 2013 00:27), Clemens Ladisch wrote:
>> +static void check_pcm_pointer(struct amdtp_stream *s,
>
> Thw word "check" does not imply that the pointers get changed.  Please
> use something like "update_pcm_pointers".

OK. I apply 'update_pcm_pointers'.

>> +static int queue_packet(struct amdtp_stream *s,
>> +{
>> +	p.skip = (!skip) ? 0: 1;
>
> 	p.skip = skip;
>
>> @@ -612,8 +618,8 @@ int amdtp_stream_start(struct amdtp_stream *s, int channel, int speed)
>>   	s->context = fw_iso_context_create(fw_parent_device(s->unit)->card,
>>   					   FW_ISO_CONTEXT_TRANSMIT,
>>   					   channel, speed, 0,
>> -					   out_packet_callback, s);
>> +					   out_stream_callback, s);
>> -	if (IS_ERR(s->context)) {
>> +	if (!amdtp_stream_running(s)) {
>
> The stream is not yet running at this point, so using this function here
> would be confusing.

OK.


Thank you.

Takashi Sakamoto