[alsa-devel] [PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

[Li Xiubo]

> > +	/* TODO: The SAI driver should figure this out for us */
> > +	switch (channels) {
> > +	case 2:
> > +		snd_soc_dai_set_tdm_slot(cpu_dai, 0xfffffffc, 0xfffffffc, 2,
> 0);
> > +		break;
> > +	case 1:
> > +		snd_soc_dai_set_tdm_slot(cpu_dai, 0xfffffffe, 0xfffffffe, 1,
> 0);
> > +		break;
> > +	default:
> > +		return -EINVAL;
> > +	}
> 
> Yes, it should - this code should probably just be copied straight into
> the SAI driver.  If we need to support other configurations we can do
> that later.
> 

Well, yes.
I have considered carefully about this, It maybe nicer to move this to SAI driver's .hw_params.



--
Best Regards,
Xiubo