[alsa-devel] [PATCH 3/3] ASOC: tegra: fix AC97 clock handling

Thierry Reding thierry.reding at gmail.com
Mon Nov 18 16:02:15 CET 2013


On Wed, Nov 13, 2013 at 08:17:23PM +0100, Lucas Stach wrote:
[...]
> diff --git a/sound/soc/tegra/tegra20_ac97.c b/sound/soc/tegra/tegra20_ac97.c
[...]
> @@ -387,24 +386,18 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev)
>  	ac97->playback_dma_data.maxburst = 4;
>  	ac97->playback_dma_data.slave_id = of_dma[1];
>  
> -	ret = tegra_asoc_utils_init(&ac97->util_data, &pdev->dev);
> -	if (ret)
> -		goto err_clk_put;
> -
> -	ret = tegra_asoc_utils_set_ac97_rate(&ac97->util_data);
> -	if (ret)
> -		goto err_asoc_utils_fini;
> +	ret = clk_set_rate(ac97->clk_ac97, 24576000);

I think this needs error checking. Just in case.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20131118/7502cf79/attachment-0001.sig>


More information about the Alsa-devel mailing list