[alsa-devel] [PATCH] ALSA: hda - Enable mute/mic-mute LEDs for more Thinkpads with Realtek codec

Takashi Iwai tiwai at suse.de
Tue Nov 19 11:30:14 CET 2013


At Tue, 19 Nov 2013 11:09:19 +0100,
David Henningsson wrote:
> 
> On 11/18/2013 01:09 PM, Takashi Iwai wrote:
> > At Mon, 18 Nov 2013 11:51:47 +0100,
> > David Henningsson wrote:
> >>
> >> We're using the ACPI interface to detect whether we're dealing with a Thinkpad
> >> or not. This way we're not loading the thinkpad_acpi module when we're not on
> >> a Thinkpad, but at the same time, we give the opportunity to check for, and
> >> potentially enable, both present and future Thinkpad with mute/micmute LEDs.
> >>
> >> At least those running the ALC269 family (269 to 299) of Realtek codecs.
> >>
> >> Cc: Alex Hung <alex.hung at canonical.com>
> >> Tested-by: Hui Wang <hui.wang at canonical.com>
> >> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
> >> ---
> >>  sound/pci/hda/patch_realtek.c |   29 ++++++++++++++++++++++++++---
> >>  1 file changed, 26 insertions(+), 3 deletions(-)
> >>
> >> Hi Takashi,
> >>
> >> Sorry I'm late with this one. I'm hoping that you can still merge it for 3.13,
> >> but if you can't, we'll just backport it into the Ubuntu 3.13 kernel instead,
> >> so not the end of the world I guess.
> > 
> > OK, I merged it now, as it's not too intrusive, 
> 
> Ok, thanks a lot!
> 
> > and the build test
> > without CONFIG_ACPI passed.
> 
> Yeah, I don't think thinkpad_acpi will stop depend on acpi anytime
> soon... :-)
> 
> Anyway, I'm attaching two more patches - one for enabling thinkpad_acpi
> on the lenovo_dock fixup (I must have missed this in the previous
> patch), and one for hda-emu.

Thanks, applied both patch.


Takashi


More information about the Alsa-devel mailing list