[alsa-devel] [patch] ALSA: isa: not allocating enough space

Takashi Iwai tiwai at suse.de
Wed Nov 13 09:29:16 CET 2013


At Wed, 13 Nov 2013 10:58:38 +0300,
Dan Carpenter wrote:
> 
> We allocate only 4 bytes here "sizeof(int)" instead of WF_MSAMPLE_BYTES
> (259) which was intended.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

Thanks, applied.


Takashi

> 
> diff --git a/sound/isa/wavefront/wavefront_synth.c b/sound/isa/wavefront/wavefront_synth.c
> index a2f87f9..e5db001 100644
> --- a/sound/isa/wavefront/wavefront_synth.c
> +++ b/sound/isa/wavefront/wavefront_synth.c
> @@ -1196,7 +1196,7 @@ wavefront_send_multisample (snd_wavefront_t *dev, wavefront_patch_info *header)
>  	int num_samples;
>  	unsigned char *msample_hdr;
>  
> -	msample_hdr = kmalloc(sizeof(WF_MSAMPLE_BYTES), GFP_KERNEL);
> +	msample_hdr = kmalloc(WF_MSAMPLE_BYTES, GFP_KERNEL);
>  	if (! msample_hdr)
>  		return -ENOMEM;
>  
> 


More information about the Alsa-devel mailing list