[alsa-devel] ASoC: add Renesas R-Car module feature

Dan Carpenter dan.carpenter at oracle.com
Fri Nov 8 11:02:06 CET 2013


Hello Kuninori Morimoto,

This is a semi-automatic email about new static checker warnings.

The patch cdaa3cdfb4a7: "ASoC: add Renesas R-Car module feature" from 
Jul 21, 2013, leads to the following Smatch complaint:

sound/soc/sh/rcar/core.c:294 rsnd_dai_connect()
	 warn: variable dereferenced before check 'mod' (see line 291)

sound/soc/sh/rcar/core.c
   290	{
   291		struct rsnd_priv *priv = rsnd_mod_to_priv(mod);
                                         ^^^^^^^^^^^^^^^^^^^^^
Dereference.

   292		struct device *dev = rsnd_priv_to_dev(priv);
   293	
   294		if (!mod) {
                    ^^^^
Check.

   295			dev_err(dev, "NULL mod\n");
   296			return -EIO;

regards,
dan carpenter


More information about the Alsa-devel mailing list