[alsa-devel] [PATCH 19/31] ASoC: sh: Use WARN_ON() instead of BUG_ON()

[Kuninori Morimoto]

At Tue,  5 Nov 2013 18:40:06 +0100,
Takashi Iwai wrote:
> 
> BUG_ON() is rather useless for debugging as it leads to panic().
> Use WARN_ON() and handle the error cases accordingly.
> 
> Cc: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> Signed-off-by: Takashi Iwai <tiwai at suse.de>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>

>  sound/soc/sh/siu_dai.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sh/siu_dai.c b/sound/soc/sh/siu_dai.c
> index 9dc24ffa892a..d55babee14f8 100644
> --- a/sound/soc/sh/siu_dai.c
> +++ b/sound/soc/sh/siu_dai.c
> @@ -543,7 +543,8 @@ static void siu_dai_shutdown(struct snd_pcm_substream *substream,
>  	/* Stop the siu if the other stream is not using it */
>  	if (!port_info->play_cap) {
>  		/* during stmread or stmwrite ? */
> -		BUG_ON(port_info->playback.rw_flg || port_info->capture.rw_flg);
> +		if (WARN_ON(port_info->playback.rw_flg || port_info->capture.rw_flg))
> +			return;
>  		siu_dai_spbstop(port_info);
>  		siu_dai_stop(port_info);
>  	}
> -- 
> 1.8.4.2
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel