[alsa-devel] [PATCH 15/31] ASoC: omap: Use WARN_ON() instead of BUG_ON()

[Jarkko Nikula]

On Tue, Nov 05, 2013 at 06:40:02PM +0100, Takashi Iwai wrote:
> BUG_ON() is rather useless for debugging as it leads to panic().
> Use WARN_ON() and handle the error cases accordingly.
> 
> Cc: Peter Ujfalusi <peter.ujfalusi at ti.com>
> Cc: Jarkko Nikula <jarkko.nikula at bitmer.com>
> Signed-off-by: Takashi Iwai <tiwai at suse.de>
> ---
>  sound/soc/omap/n810.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/omap/n810.c b/sound/soc/omap/n810.c
> index 5e8d640d314f..6d216cb6c19b 100644
> --- a/sound/soc/omap/n810.c
> +++ b/sound/soc/omap/n810.c
> @@ -344,8 +344,11 @@ static int __init n810_soc_init(void)
>  	clk_set_parent(sys_clkout2_src, func96m_clk);
>  	clk_set_rate(sys_clkout2, 12000000);
>  
> -	BUG_ON((gpio_request(N810_HEADSET_AMP_GPIO, "hs_amp") < 0) ||
> -	       (gpio_request(N810_SPEAKER_AMP_GPIO, "spk_amp") < 0));
> +	if (WARN_ON((gpio_request(N810_HEADSET_AMP_GPIO, "hs_amp") < 0) ||
> +		    (gpio_request(N810_SPEAKER_AMP_GPIO, "spk_amp") < 0))) {

Strong ack! (/me wondering why I put it there in the first place)

Acked-by: Jarkko Nikula <jarkko.nikula at bitmer.com>