[alsa-devel] [PATCH] ASoC: sgtl5000: Fix VAG_POWER enabling/disabling order

[Marek Vasut]

Dear Mark Brown,

> On Fri, May 24, 2013 at 05:34:56AM +0200, Marek Vasut wrote:
> > -	case SND_SOC_DAPM_POST_PMD:
> > 
> > +	case SND_SOC_DAPM_PRE_PMD:
> >  		snd_soc_update_bits(w->codec, SGTL5000_CHIP_ANA_POWER,
> >  		
> >  			SGTL5000_VAG_POWERUP, 0);
> > 
> > -		msleep(400);
> > +		mdelay(400);
> > 
> >  		break;
> 
> This looks to be both unrelated and a regression - mdelay() should be
> more resource intensive than sleeping and if it's 400ms we shouldn't be
> that worried about delaying slightly longer.

Definitelly, this was not supposed to be part of the patch. Fixed in V2.

> Please note my updated mail address which I've been using for a while
> now, the Wolfson one will go bad at the end of the week.

Roger. I hope you have a good time at your new position :)

Best regards,
Marek Vasut