[alsa-devel] [PATCH 1/3] lx6464es: remove useles pci_set_drvdata(pdev, NULL)

Takashi Iwai tiwai at suse.de
Wed May 29 12:17:17 CEST 2013


At Wed, 29 May 2013 13:03:20 +0300,
Andy Shevchenko wrote:
> 
> The driver core handles this.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>

Thanks, but I already queued a clean-up patch to remove the whole
pci_set_drvdata() with NULL for all sound/* pci drivers.


Takashi

> ---
>  sound/pci/lx6464es/lx6464es.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c
> index 298bc9b..3230e57 100644
> --- a/sound/pci/lx6464es/lx6464es.c
> +++ b/sound/pci/lx6464es/lx6464es.c
> @@ -1139,7 +1139,6 @@ out_free:
>  static void snd_lx6464es_remove(struct pci_dev *pci)
>  {
>  	snd_card_free(pci_get_drvdata(pci));
> -	pci_set_drvdata(pci, NULL);
>  }
>  
>  
> -- 
> 1.8.2.rc0.22.gb3600c3
> 


More information about the Alsa-devel mailing list