[alsa-devel] [PATCH] ASoC: Add ssm2518 support

[Mark Brown]

On Wed, May 22, 2013 at 08:16:36PM +0200, Lars-Peter Clausen wrote:
> On 05/22/2013 07:57 PM, Mark Brown wrote:

> >> +	if (slots == 0) {
> >> +		return regmap_update_bits(ssm2518->regmap,
> >> +			SSM2518_REG_SAI_CTRL1, SSM2518_SAI_CTRL1_SAI_MASK,
> >> +			SSM2518_SAI_CTRL1_SAI_I2S);
> >> +	}

> > You've got quite a few single statement if () blocks with { } which
> > shouldn't be there.
> > 

> I prefer to only do this for single single-line statements.

That's not the kernel coding style and I have to say these examples were
all jumping out at me as weird, I was looking for an else clause or
something.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130522/e31c3e18/attachment.sig>