[alsa-devel] [PATCH 7/8] Avoid including sys/io.h on architectures that lack it.

[Takashi Iwai]

At Wed, 15 May 2013 19:19:10 +0200,
Jordi Mallach wrote:
> 
> Extend the check for PowerPC to the rest of official and unofficial
> Debian linux-based architectures that lack sys/io.h, based on EGLIBC 2.17.
> sys/io.h is available, at the time of this writing, on the alpha, i386,
> ia64, and arm Linux targets.
> 
> Signed-off-by: Jordi Mallach <jordi at debian.org>
> ---
>  hda-verb/hda-verb.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/hda-verb/hda-verb.c b/hda-verb/hda-verb.c
> index bd746ad..2b85923 100644
> --- a/hda-verb/hda-verb.c
> +++ b/hda-verb/hda-verb.c
> @@ -13,7 +13,11 @@
>  #include <ctype.h>
>  #include <unistd.h>
>  #include <sys/ioctl.h>
> -#ifndef __PPC__
> +/* EGLIBC 2.17 supports sys/io.h for alpha, i386, ia64, arm,
> +   hurd-i386, and kfreebsd-i386. */
> +#if !defined (__powerpc__) && !defined (__sparc__) && !defined (__s390__) && \
> +    !defined (__mips__) && !defined (__hppa__) && !defined (__m68k__) && \
> +    !defined (__sh__)
>  #include <sys/io.h>
>  #endif
>  #include <sys/types.h>

If the change starts looking like this, better to consider what you're
really doing :)

Dropping the inclusion of sys/io.h is the right fix.


thanks,

Takashi