[alsa-devel] [PATCH 08/14] ASoC: speaer_pcm: No need to use snd_dmaengine_pcm_set_data()

[Lars-Peter Clausen]

On 03/25/2013 04:59 AM, Rajeev kumar wrote:
> Hello Lars,
> 
> On 3/22/2013 6:42 PM, Lars-Peter Clausen wrote:
>> The driver never uses snd_dmaengine_pcm_get_data(), so there is no
>> need to use
>> snd_dmaengine_pcm_set_data().
>>
>> Signed-off-by: Lars-Peter Clausen<lars at metafoo.de>
>> Cc: Rajeev Kumar<rajeev-dlh.kumar at st.com>
>> ---
>>   sound/soc/spear/spear_pcm.c | 8 +-------
>>   1 file changed, 1 insertion(+), 7 deletions(-)
>>
>> diff --git a/sound/soc/spear/spear_pcm.c b/sound/soc/spear/spear_pcm.c
>> index 903ac15..bfbcc1f 100644
>> --- a/sound/soc/spear/spear_pcm.c
>> +++ b/sound/soc/spear/spear_pcm.c
>> @@ -64,13 +64,7 @@ static int spear_pcm_open(struct snd_pcm_substream
>> *substream)
>>       if (ret)
>>           return ret;
>>
>> -    ret = snd_dmaengine_pcm_open(substream, dma_data->filter, dma_data);
>> -    if (ret)
>> -        return ret;
>> -
>> -    snd_dmaengine_pcm_set_data(substream, dma_data);
> 

Hi,

> The dma data is used to set dma parameters to transfer data and it will
> required by the dma engine.
> 

snd_dmaengine_pcm_set_data() sets private data for the dmaengine pcm, this data
can be retrieved later using snd_dmaengine_pcm_get_data(). The spear pcm driver
never uses snd_dmaengine_pcm_get_data(), so calling
snd_dmaengine_pcm_set_data() shouldn't be necessary.

- Lars