[alsa-devel] [PATCH 2/2 resend] ASoC: cs4271: preserve "Master Playback Switch" setting

[Daniel Mack]

On 22.03.2013 11:32, Mark Brown wrote:
> On Fri, Mar 22, 2013 at 11:23:32AM +0100, Daniel Mack wrote:
>> On 22.03.2013 11:18, Mark Brown wrote:
> 
>>> The usual fix for this is to just not have the mute operation if it's
>>> important.  Otherwise this seems like something we ought to implement in
>>> the core, it's not a silly feature by any stretch of the imagination but
>>> it applies to any device with a DAI mute unless there's some device
>>> specific thing I'm missing here.
> 
>> So I'd say having a simple OR logic in this case is reasonable and
>> serves all the needs I can think of, no?
> 
> You're not really responding to what I'm saying here.  What I'm saying
> is that if this is useful it should be implemented in the core unless
> there's some reason I'm missing why this is specific to this driver.

Ok, point taken. It's just not really a drop-in equivalent, given that
both the numid and the name string will change then.

I'll see when I'll find some time to do that. Your idea is to have a
"Master Playback Switch" for both the CPU and the Codec on each link, if
the driver implements either ->mute_stream or ->digital_mute, right? And
the control would default to "on"?


Thanks,
Daniel