[alsa-devel] [PATCH 19/54 v2] ASoC: switch over to use snd_soc_register_component() on mpc5200 i2s

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Fri Mar 22 02:19:51 CET 2013


Hi Stephen

Thank you for pointing it

> > diff --git a/sound/soc/fsl/mpc5200_psc_i2s.c b/sound/soc/fsl/mpc5200_psc_i2s.c
> 
> > @@ -163,7 +167,8 @@ static int psc_i2s_of_probe(struct platform_device *op)
> >  	if (rc != 0)
> >  		return rc;
> >  
> > -	rc = snd_soc_register_dais(&op->dev, psc_i2s_dai, ARRAY_SIZE(psc_i2s_dai));
> > +	rc = snd_soc_register_component(&op->dev, &psc_i2s_component,
> > +					psc_i2s_dai, ARRAY_SIZE(psc_i2s_dai));
> 
> ARRAY_SIZE(psc_i2s_dai)==1, so this switches from
> snd_soc_register_dais() to snd_soc_register_dai(). Will that be a problem?

I didn't notice about it.

arch/powerpc/boot/dts/lite5200.dts seems the user of this driver,
but, it was comment-outed.
And it is using DT, not name matching ?

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list