[alsa-devel] [PATCH v2] davinci-mcasp: Add support for multichannel playback

[Bedia, Vaibhav]

On Tue, Mar 05, 2013 at 17:11:20, Michal Bachraty wrote:
> Hi Vaibhav,
> 
> Please look at  [alsa-devel] [PATCH v3] davinci-mcasp: Add support for 
> multichannel playback thread. 
> There was some changes about computing number of channels. There is also 
> described, how this driver works.

Oops. I somehow missed v3 :(

I just had a look at it and most the comments that I have on v2 are still
applicable and IMO need to be addressed before getting merged. You also don't
have a change-log in v3 so I don't understand why you made some changes.

> Also please look at [alsa-devel] davici-mcasp: "tx-num-evt" confusion with 
> number of serializers thread, where are discussed using "tx-num-evt".
> 

Just noticed this one. Will respond to it.

> I tested driver with 2 - 4 - 6 - 8 channnels I2S (2 slots TDM) with using 1 -2 
> -3 -4 serializers. and S16_LE (will do S24_3LE) audio.

Did you use aplay for this? If so, what were the parameters used. If not, can you
describe how the userspace needs to manage the audio buffer? For anyone looking
at leveraging the multi-serializer feature this information is important to
highlight.

Regards,
Vaibhav