[alsa-devel] [RFC PATCH v2 04/12] dmaengine: PL08x: Add support for PL080S variant

[Linus Walleij]

On Sat, Jun 22, 2013 at 10:42 PM, Tomasz Figa <tomasz.figa at gmail.com> wrote:

> @@ -96,7 +96,11 @@ enum {
>         PL080_LLI_LLI,
>         PL080_LLI_CCTL,
>
> -       PL080_LLI_WORDS
> +       PL080_LLI_WORDS,
> +
> +       PL080S_LLI_CCTL2 = PL080_LLI_WORDS,
> +
> +       PL080S_LLI_WORDS = 8
>  };

I still think it's better to just #define these and write
some comments. Now I have to think backwards that
I am the compiler enumerating these things and it's all
a bit confusing.

Apart from that it looks nice.

Yours,
Linus Walleij