[alsa-devel] cs42l52 alsa driver broken beep volume control

Lars-Peter Clausen lars at metafoo.de
Thu Jun 20 10:34:26 CEST 2013


Hi,

I stumbled upon this while making some changes to the SOC_SINGLE_VALUE
macro. For the Beep Volume control the cs42l52 driver sets the invert field
to 7, which doesn't make much sense and is causing a build warning with my
changes. I assume the intention was to actually use SOC_SINGLE_SX_TLV
instead of SOC_SINGLE_TLV. But I'm not sure if setting min to 0x1f and max
0x7 is right either. Also according to the datasheet the tlv dB info seems
to be wrong. The Beep Volume uses 2dB steps while the info uses 0.5dB steps.

- Lars


More information about the Alsa-devel mailing list