[alsa-devel] [RFC PATCH 04/11] dma: amba-pl08x: Add support for PL080S variant
Tomasz Figa
tomasz.figa at gmail.com
Mon Jun 17 20:22:41 CEST 2013
On Monday 17 of June 2013 15:39:34 Linus Walleij wrote:
> On Sun, Jun 16, 2013 at 10:54 PM, Tomasz Figa <tomasz.figa at gmail.com>
wrote:
> > PL080S is a modified version of PL080 that can be found on Samsung
> > SoCs, such as S3C6400 and S3C6410.
> >
> > It has different offset of CONFIG register, separate CONTROL1 register
> > that holds transfer size and larger maximum transfer size.
> >
> > Signed-off-by: Tomasz Figa <tomasz.figa at gmail.com>
>
> Acked-by: Linus Walleij <linus.walleij at linaro.org>
>
> (I would have done some smallish things differently but it
> is only a matter of taste.)
>
> > static struct amba_id pl08x_ids[] = {
> >
> > + /* Samsung PL080S variant */
> > + {
> > + .id = 0x0a141080,
> > + .mask = 0xffffffff,
> > + .data = &vendor_pl080s,
> > + },
>
> Interesting that Samsung claim to be vendor 0x41
> (ARM).
Yeah, I had identical thought when I saw it first time.
> Well ARM never made revision no 0x0a so
> this works.
Good, this is exactly what I wanted to read! ;)
I was afraid that this ID might conflict with some revision of normal
PL080, but fortunately it is not the case.
Best refards,
Tomasz
More information about the Alsa-devel
mailing list