[alsa-devel] [PATCH] ASoC: wm0010: Fix resource leak
Dimitris Papastamos
dp at opensource.wolfsonmicro.com
Wed Jul 31 14:03:01 CEST 2013
On Wed, Jul 31, 2013 at 01:00:25PM +0100, Dimitris Papastamos wrote:
> On Wed, Jul 31, 2013 at 12:23:31PM +0100, Mark Brown wrote:
> > On Wed, Jul 31, 2013 at 10:15:18AM +0100, Dimitris Papastamos wrote:
> >
> > > + xfer = kzalloc(sizeof(*xfer), GFP_KERNEL | GFP_DMA);
> > > + if (!xfer) {
> > > + dev_err(codec->dev, "Failed to allocate xfer\n");
> > > + ret = -ENOMEM;
> > > + goto abort1;
> > > + }
> > > +
> >
> > Why is this being allocated with GFP_DMA? It's an internal data
> > structure, it's not going to be DMAed from.
>
> Yeah I will send a separate patch to fix that and then rebase
> this patch on top.
Aw just noticed, this is basically a git am conflict that I resolved
incorrectly.
More information about the Alsa-devel
mailing list