[alsa-devel] [PATCH - Preliminary support for Xonar Xense (resubmitAdded support for Xonar Xense. Only speaker out and mic in working.

Clemens Ladisch clemens at ladisch.de
Tue Jul 30 19:23:43 CEST 2013


Ian Dawes wrote:
> On 30/07/13 07:36, Clemens Ladisch wrote:
>> Ian Dawes wrote:
>>> Clemens Ladisch <clemens at ladisch.de> wrote:
>>>> Ian Dawes wrote:
>>>>> Clemens Ladisch <clemens at ladisch.de> wrote:
>>>>>> Ian Dawes wrote:
>>>>>>> Signed-off-by: Ian Dawes <madeallup.gen at gmail.com>
>>>>>> The commit message was squashed into the subject line.  There's
>>>>>> probably an empty line missing between them.
>>>>> I'm not sure what this means.
>>>> Did you intend for the subject to be this long?
>>> Probably not. I added "resubmitted" to the subject
>> And the "Added support ..." was supposed to be in the subject, too?
>>
>>> How should I rectify this?
>> Ensure there is an empty line after the subject.
>
> Should I resubmit the patch then? (with the additional channels removed and fixed subject line)

Yes, please.


Regards,
Clemens


More information about the Alsa-devel mailing list