[alsa-devel] [PATCH] ASoC: fsl: Fix module build

[Shawn Guo]

On Tue, Jul 30, 2013 at 09:53:21AM -0300, Fabio Estevam wrote:
> Hi Shawn,
> 
> On Tue, Jul 30, 2013 at 4:55 AM, Shawn Guo <shawn.guo at linaro.org> wrote:
> 
> > What tree?  I tested linux-next 20130730 and did not see the error.
> 
> Just tested it with linux-next 20130730 and could reproduce the error
> there as well.
> 
> You can apply the attached patch and you will see the error.

I see the difference here.  With my build, I only set CONFIG_SND_IMX_SOC
to 'm', while you set CONFIG_SND to 'm'.

As imx-pcm-fiq is only used by imx-ssi and imx-pcm-dma is pretty small,
I thought that it's not worth to build imx-pcm-fiq and imx-pcm-dma as
modules, and having them be 'bool' and then link them into imx-ssi
and fsl-ssi should also work.  But I see Markus is working on fsl-ssi
to adopt imx-pcm-fiq.  And imx-pcm-fiq is still big, it makes some sense
to build them as modules.  So,

Acked-by: Shawn Guo <shawn.guo at linaro.org>

Shawn