[alsa-devel] [PATCH] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION

[Takashi Iwai]

At Sun, 28 Jul 2013 20:04:03 +0530,
Vinod Koul wrote:
> 
> Reported-by: Haynes <hgeorge at codeaurora.org>
> CC: stable at vger.kernel.org
> Signed-off-by: Vinod Koul <vinod.koul at intel.com>

The fix is trivial, but please give a bit more description so that
people can understand what this commit does and why it's needed,
without reading the code change but only from the patch description.


thanks,

Takashi

> ---
>  sound/core/compress_offload.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
> index 99db892..9896954 100644
> --- a/sound/core/compress_offload.c
> +++ b/sound/core/compress_offload.c
> @@ -743,7 +743,7 @@ static long snd_compr_ioctl(struct file *f, unsigned int cmd, unsigned long arg)
>  	mutex_lock(&stream->device->lock);
>  	switch (_IOC_NR(cmd)) {
>  	case _IOC_NR(SNDRV_COMPRESS_IOCTL_VERSION):
> -		put_user(SNDRV_COMPRESS_VERSION,
> +		retval = put_user(SNDRV_COMPRESS_VERSION,
>  				(int __user *)arg) ? -EFAULT : 0;
>  		break;
>  	case _IOC_NR(SNDRV_COMPRESS_GET_CAPS):
> -- 
> 1.7.0.4
>