[alsa-devel] [PATCH 0/10] snd_pcm_stop() lock fixes

[Lars-Peter Clausen]

On 07/16/2013 05:10 PM, Takashi Iwai wrote:
> At Tue, 16 Jul 2013 16:54:14 +0200,
> Lars-Peter Clausen wrote:
>>
>> On 07/16/2013 04:48 PM, Takashi Iwai wrote:
>> [...]
>>> +int snd_pcm_lock_and_stop(struct snd_pcm_substream *substream, snd_pcm_state_t state)
>>
>> The name makes it sound as if the lock will still be held after the function
>> call has completed.
> 
> Yeah, I agree with my bad sense of naming...
> 
>> How about snd_pcm_stop_locked()?
> 
> Hrm, it's also unclear whether it's called in a locked context or it
> does lock by itself.

Hm, I always thought that ..._locked() was mainly used for functions that
take the lock, but a quick grep revealed that both meanings are used and
it's split about 50/50 :/

- Lars