[alsa-devel] [PATCH 08/10] ASoC: s6000: Fix unlocked snd_pcm_stop() call

[Takashi Iwai]

At Mon, 15 Jul 2013 18:02:48 +0200,
Daniel Glöckner wrote:
> 
> Nack
> 
> On Mon, Jul 15, 2013 at 03:06:20PM +0200, Takashi Iwai wrote:
> > --- a/sound/soc/s6000/s6000-pcm.c
> > +++ b/sound/soc/s6000/s6000-pcm.c
> > @@ -128,7 +128,9 @@ static irqreturn_t s6000_pcm_irq(int irq, void *data)
> >  		    substream->runtime &&
> >  		    snd_pcm_running(substream)) {
> >  			dev_dbg(pcm->dev, "xrun\n");
> > +			snd_pcm_stream_lock(substream);
> >  			snd_pcm_stop(substream, SNDRV_PCM_STATE_XRUN);
> > +			snd_pcm_substream_unlock(substream);
> 
> I think this is supposed to be a call to snd_pcm_stream_unlock.

Bah, thanks, fixed now.

This didn't go through my build test, obviously...


Takashi