[alsa-devel] [PATCH 3/6] ASoC: add Renesas R-Car Generation feature

[Kuninori Morimoto]

Hi Mark

> On Sun, Jun 30, 2013 at 11:53:10PM -0700, Kuninori Morimoto wrote:
> 
> > +u32 rsnd_read(struct rsnd_priv *priv,
> > +	      struct rsnd_mod *mod, enum rsnd_reg reg)
> > +{
> > +	void __iomem *base = rsnd_gen_reg_get(priv, mod, reg);
> > +
> > +	BUG_ON(!base);
> > +
> > +	return ioread32(base);
> > +}
> 
> regmap?  I don't know if the new regmap field API helps with the fact
> that some of the registers have been moved about.

This rsnd_gen_reg_get() is absorbing Gen1/Gen2 and
ADG/SSI/SCU/SRU mixed register mapping

> > +static void rsnd_gen2_remove(struct platform_device *pdev,
> > +			     struct rsnd_priv *priv)
> > +{
> > +}
> 
> There's quite a few empty functions here - it'd be better to be able to
> avoid them.

I see. I will remove it on v2 patch.