[alsa-devel] [PATCH] ASoC: add ak4554 driver

[Mark Brown]

On Sun, Jun 30, 2013 at 11:43:51PM -0700, Kuninori Morimoto wrote:

> ak4554 is very simple DA/AD converter which has no setting register.
> But, playback format is SND_SOC_DAIFMT_RIGHT_J,
> and, capture  format is SND_SOC_DAIFMT_LEFT_J on same bit clock, LR clock.
> Because of that, snd_soc_dai_driver consists from
> "playback only" and "capture only" here,
> and it has software base symmetric_rates check.

If the device is hard coded to these formats just use a single DAI
without a set_dai_fmt() operation, either the machine can create two
links to the DAI or things can be set up without any extra clocks so
that both formats are met.  Otherwise this looks good apart from the
things Lars-Peter already noticed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130702/12c4208e/attachment.sig>