[alsa-devel] [PATCH - my module 1/1] Fix a memory access violation resulting from improper error propogation.

allan at allanwirth.com allan at allanwirth.com
Thu Jan 31 19:55:33 CET 2013


From: Allan Wirth <allan at allanwirth.com>

Fixes an issue where a variable is used undeclared, which can cause seg
faults on some systems if the configuration file is not formatted
properly.

Signed-off-by: Allan Wirth <allan at allanwirth.com>

diff --git a/src/conf.c b/src/conf.c
index ecaa339..4ba5863 100644
--- a/src/conf.c
+++ b/src/conf.c
@@ -3530,7 +3530,7 @@ int snd_config_hook_load(snd_config_t *root, snd_config_t *config, snd_config_t
 				if (err < 0)
 					goto _err;
 			}
-		} else if (config_file_open(root, fi[idx].name) < 0)
+		} else if ((err = config_file_open(root, fi[idx].name)) < 0)
 			goto _err;
 	}
 	*dst = NULL;
-- 
1.7.10.4



More information about the Alsa-devel mailing list