[alsa-devel] [PATCH] ASoC: tlv320aic3x: Fix mono

[Benoît Thébaudeau]

On Wednesday, January 30, 2013 3:11:45 AM, Mark Brown wrote:
> On Tue, Jan 29, 2013 at 09:40:18PM +0100, Benoît Thébaudeau wrote:
> > On Tuesday, January 29, 2013 3:01:32 AM, Mark Brown wrote:
> 
> > > Why are you having to call this in the first place?
> 
> > For I²S, because the reference manual of the i.MX25 says that SSI.STCCR.DC
> > should be set to 1 (i.e. 2 channels) in this mode. This also allowed to
> > test
> > several settings for mono.
> 
> > For DSP modes, because stereo doesn't work without this call (right channel
> > missing).
> 
> So why does the driver not just do this automatically?

I don't know. I add Fabio and Sascha to Cc in case they know.

I think that it's either to let the users of imx-ssi do weird things if they
have to (but implementing a default setup would not prevent users to change it
by calling snd_soc_dai_set_tdm_slot(), so...), or rather because nobody had
enough time or all the test configurations to work on this so far. It's marked
as TODO in sound/soc/fsl/wm1133-ev1.c.

Best regards,
Benoît