[alsa-devel] [PATCH 03/19] ALSA: ymu831: add B-DSP driver

Yoichi Yuasa yuasa at linux-mips.org
Thu Jan 17 06:58:45 CET 2013


On Wed, 16 Jan 2013 12:49:37 +0100
Takashi Iwai <tiwai at suse.de> wrote:

> At Wed, 16 Jan 2013 17:28:32 +0900,
> Yoichi Yuasa wrote:
> > 
> > +static void bdsp_check_sin_control_sel(struct aec_bdsp_info *bdsp, u8 *data)
> > +{
> > +	u32 addr;
> > +	u32 size;
> > +
> > +	addr = htonl(*(u32 *) data);
> > +	size = htonl(*(u32 *) (data + 5));
> 
> It's an unaligned access. 

The size is unaligned.
I'll add a comment.

> And normally we use cpu_to_xxx() or
> xxx_to_cpu() macros for endian conversions.

I'll update them.

Thank you for your comment.

Yoichi


More information about the Alsa-devel mailing list