[alsa-devel] [PATCH 02/19] ALSA: ymu831: add device register definitions

[Mark Brown]

On Wed, Jan 16, 2013 at 05:27:04PM +0900, Yoichi Yuasa wrote:
> 
> Signed-off-by: Yoichi Yuasa <yuasa at linux-mips.org>

Please follow the patch submission process in SubmittingPatches.

> + * Module	: mcdefs.h
> + * Description	: MC device definitions
> + * Version	: 1.0.1	Dec 18 2012
> + *
> + * This software is provided 'as-is', without any express or implied
> + * warranty.	In no event will the authors be held liable for any damages
> + * arising from the use of this software.
> + *
> + * Permission is granted to anyone to use this software for any purpose,
> + * including commercial applications, and to alter it and redistribute it
> + * freely, subject to the following restrictions:
> + *
> + * 1. The origin of this software must not be misrepresented; you must not
> + *	claim that you wrote the original software. If you use this software
> + *	in a product, an acknowledgment in the product documentation would be
> + *	appreciated but is not required.
> + * 2. Altered source versions must be plainly marked as such, and must not be
> + *	misrepresented as being the original software.
> + * 3. This notice may not be removed or altered from any source distribution.

It's not entirely clear to me that this is GPL compatible... 

> +#define MCI_A_REG_A			0
> +#define MCB_A_REG_AINC			0x80

All these definitions need to be namespaced.