[alsa-devel] [PATCH] ALSA: hda - Switch "On" and "Off" for "Mute-LED Mode" kcontrol

Takashi Iwai tiwai at suse.de
Thu Jan 3 14:32:03 CET 2013


At Thu,  3 Jan 2013 14:12:29 +0100,
David Henningsson wrote:
> 
> The vmaster hook sends 1 for enabled/unmuted and 0 for disabled/muted,
> but "Mute-LED Mode" being "On" refers to the LED being on, not the
> volume being on.
> Therefore "On" and "Off" should be switched.
> 
> Signed-off-by: David Henningsson <david.henningsson at canonical.com>

Thanks, applied.


Takashi

> ---
>  sound/pci/hda/hda_codec.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
> index 8353c77..b8fb0a5 100644
> --- a/sound/pci/hda/hda_codec.c
> +++ b/sound/pci/hda/hda_codec.c
> @@ -2531,7 +2531,7 @@ static int vmaster_mute_mode_info(struct snd_kcontrol *kcontrol,
>  				  struct snd_ctl_elem_info *uinfo)
>  {
>  	static const char * const texts[] = {
> -		"Off", "On", "Follow Master"
> +		"On", "Off", "Follow Master"
>  	};
>  	unsigned int index;
>  
> -- 
> 1.7.9.5
> 


More information about the Alsa-devel mailing list