[alsa-devel] [PATCH 4/5] ASoC: max98090: Remove unnecessary braces

Sachin Kamat sachin.kamat at linaro.org
Mon Feb 25 05:14:52 CET 2013


On 20 February 2013 22:22, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Mon, Feb 18, 2013 at 05:02:13PM +0530, Sachin Kamat wrote:
>
>> -     if (val >= 1) {
>> -             if (w->reg == M98090_REG_MIC1_INPUT_LEVEL) {
>> +     if (val >= 1){
>
> Your coding style fixes shouldn't introduce new coding style issues

Sorry for the error on my part. I have fixed this in the updated version.

> and...
>
>> +             if (w->reg == M98090_REG_MIC1_INPUT_LEVEL)
>
> ...in cases where you're nesting with other if statements it's often
> clearer to have the braces consistently over all levels of the
> conditional.

Right. I have retained them in nested cases.


More information about the Alsa-devel mailing list