[alsa-devel] [PATCH] ALSA: Add params_width() helpers

Takashi Iwai tiwai at suse.de
Tue Dec 24 15:04:16 CET 2013


At Tue, 24 Dec 2013 12:24:28 +0000,
Mark Brown wrote:
> 
> From: Mark Brown <broonie at linaro.org>
> 
> Add helpers for obtaining the width of a format directly from params
> since this is expected to become a common operation in ASoC.
> 
> Signed-off-by: Mark Brown <broonie at linaro.org>

Looks good.  Since you seem to have already codes using these
helpers, feel free to take it via your tree with my ack, then I'll
pull yours later.

Reviewed-by: Takashi Iwai <tiwai at suse.de>


thanks,

Takashi

> ---
>  include/sound/pcm_params.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/include/sound/pcm_params.h b/include/sound/pcm_params.h
> index 37ae12e..6b1c78f 100644
> --- a/include/sound/pcm_params.h
> +++ b/include/sound/pcm_params.h
> @@ -354,4 +354,16 @@ params_period_bytes(const struct snd_pcm_hw_params *p)
>  		params_channels(p)) / 8;
>  }
>  
> +static inline int
> +params_width(const struct snd_pcm_hw_params *p)
> +{
> +	return snd_pcm_format_width(params_format(p));
> +}
> +
> +static inline int
> +params_physical_width(const struct snd_pcm_hw_params *p)
> +{
> +	return snd_pcm_format_physical_width(params_format(p));
> +}
> +
>  #endif /* __SOUND_PCM_PARAMS_H */
> -- 
> 1.8.5.2
> 


More information about the Alsa-devel mailing list