[alsa-devel] [PATCH] ASoC: tlv320aic3x: Correct S24_3LE support

[Mark Brown]

On Fri, Dec 13, 2013 at 02:41:44PM +0100, Takashi Iwai wrote:
> Mark Brown wrote:

> > No, I'd expect the wire behaviour to be identical for any 24 bit samples
> > (that's certainly what most drivers are written for).  The memory layout
> > differences shouldn't be visible to CODEC drivers.

> > Like I say we ought to be handling this stuff in the core :/

> But this codec driver declares the available formats as:

> #define AIC3X_FORMATS	(SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | \
> 			 SNDRV_PCM_FMTBIT_S24_3LE | SNDRV_PCM_FMTBIT_S32_LE)

> so the fix for inconsistency is needed anyway.

Ah, indeed - and that one should go to stable.  The changelog ought to
be more accurate though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20131213/2767cf75/attachment.sig>